From 1ebaee3f344c498aedfba542cf0a2200c4d1d88f Mon Sep 17 00:00:00 2001
From: Markus Katharina Brechtel <markus.katharina.brechtel@thengo.net>
Date: Sun, 12 Nov 2017 15:49:13 +0000
Subject: [PATCH] improvements

---
 tasks/configure.yml |  3 +++
 tasks/customize.yml |  3 +++
 tasks/install.yml   | 13 ++++---------
 tasks/nodenv.yml    | 19 +++++++++----------
 tasks/rbenv.yml     | 19 +++++++++----------
 5 files changed, 28 insertions(+), 29 deletions(-)

diff --git a/tasks/configure.yml b/tasks/configure.yml
index baf34a8..7082ae2 100644
--- a/tasks/configure.yml
+++ b/tasks/configure.yml
@@ -8,6 +8,9 @@
     - database
     #- configuration
   notify: restart openproject
+  become: yes
+  become_user: '{{openproject_user}}'
+  become_method: su
 
 # https://community.openproject.com/projects/openproject/work_packages/26147/activity
 # - name: fix openproject bug \#26147
diff --git a/tasks/customize.yml b/tasks/customize.yml
index 6200834..61bc86d 100644
--- a/tasks/customize.yml
+++ b/tasks/customize.yml
@@ -5,3 +5,6 @@
     content: ""
     dest: "{{openproject_path}}/openproject/app/views/homescreen/blocks/_upsale.html.erb"
   notify: restart openproject
+  become: yes
+  become_user: '{{openproject_user}}'
+  become_method: su
diff --git a/tasks/install.yml b/tasks/install.yml
index c9635e3..438c86c 100644
--- a/tasks/install.yml
+++ b/tasks/install.yml
@@ -25,6 +25,7 @@
     - libxml2
     - libxml2-dev
     - libxslt1-dev
+    - libsqlite3-dev
 
 - name: clone openproject
   git:
@@ -36,15 +37,9 @@
   poll: 1
   register: cloned_openproject
   notify: restart openproject
-
-# do not run this as a handler but as a task here because we will need this before
-# end of playbook execution.
-- name: change ownership of openproject
-  file:
-    path: '{{openproject_path}}/openproject'
-    owner: '{{openproject_user}}'
-    group: '{{openproject_group}}'
-    recurse: yes
+  become: yes
+  become_user: '{{openproject_user}}'
+  become_method: su
 
 - name: install bundler
   gem:
diff --git a/tasks/nodenv.yml b/tasks/nodenv.yml
index 8dd2eb9..18797da 100644
--- a/tasks/nodenv.yml
+++ b/tasks/nodenv.yml
@@ -6,6 +6,9 @@
     dest: "{{nodenv_directory}}"
     depth: 1
   register: cloned_nodenv
+  become: yes
+  become_user: '{{nodenv_user}}'
+  become_method: su
 
 - name: setup nodenv
   lineinfile:
@@ -14,6 +17,9 @@
   with_items:
   - 'export PATH="{{nodenv_directory}}/bin:$PATH"'
   - 'eval "$(nodenv init -)"'
+  become: yes
+  become_user: '{{nodenv_user}}'
+  become_method: su
 
 - name: setup node-build
   git:
@@ -21,16 +27,9 @@
     dest: "{{nodenv_directory}}/plugins/node-build"
     depth: 1
   register: cloned_node_build
-
-# do not run this as a handler but as a task here because we will need this before
-# end of playbook execution.
-- name: change ownership of nodenv
-  file:
-    path: "{{nodenv_directory}}"
-    owner: '{{nodenv_user}}'
-    group: '{{nodenv_group}}'
-    recurse: yes
-  when: cloned_node_build.changed or cloned_nodenv.changed
+  become: yes
+  become_user: '{{nodenv_user}}'
+  become_method: su
 
 - name: get installed node versions
   command: nodenv versions
diff --git a/tasks/rbenv.yml b/tasks/rbenv.yml
index 293b81a..e818ccd 100644
--- a/tasks/rbenv.yml
+++ b/tasks/rbenv.yml
@@ -26,6 +26,9 @@
     dest: "{{rbenv_directory}}"
     depth: 1
   register: cloned_rbenv
+  become: yes
+  become_user: '{{rbenv_user}}'
+  become_method: su
 
 - name: setup rbenv
   lineinfile:
@@ -34,6 +37,9 @@
   with_items:
   - 'export PATH="{{rbenv_directory}}/bin:$PATH"'
   - 'eval "$(rbenv init -)"'
+  become: yes
+  become_user: '{{rbenv_user}}'
+  become_method: su
 
 - name: setup ruby-build
   git:
@@ -41,16 +47,9 @@
     dest: "{{rbenv_directory}}/plugins/ruby-build"
     depth: 1
   register: cloned_ruby_build
-
-# do not run this as a handler but as a task here because we will need this before
-# end of playbook execution.
-- name: change ownership of rbenv
-  file:
-    path: "{{rbenv_directory}}"
-    owner: '{{rbenv_user}}'
-    group: '{{rbenv_group}}'
-    recurse: yes
-  when: cloned_ruby_build.changed or cloned_rbenv.changed
+  become: yes
+  become_user: '{{rbenv_user}}'
+  become_method: su
 
 - name: get installed ruby versions
   command: rbenv versions